-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solve the problem of the tag input becoming a title after the # symbol #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
有冲突需要解决 |
…to fix/tag-select-enter
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
由于
ExtensionHeading
的输入规则与 moment 的ExtensionTag
规则相冲突,导致输入#
号之后按回车会变为标题。也尝试过将 Priority 设置为较大的数值。但并没有效果,因为
ExtensionTag
是Mark
而ExtensionHeading
是一个Node
,因此他们之间的输入规则会同时触发。综上所述,目前采取的策略是移除
ExtensionHeading
扩展。此改动需要 Halo 2.12.0 的支持。
How to test it?
在 moment 页面中输入
#
后按回车,查看是否变为标签而不是其他内容。Which issue(s) this PR fixes:
Fixes #65
Does this PR introduce a user-facing change?