Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve the problem of the tag input becoming a title after the # symbol #75

Merged
merged 5 commits into from
May 6, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 1, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

由于 ExtensionHeading 的输入规则与 moment 的 ExtensionTag 规则相冲突,导致输入 # 号之后按回车会变为标题。

也尝试过将 Priority 设置为较大的数值。但并没有效果,因为 ExtensionTagMarkExtensionHeading 是一个 Node,因此他们之间的输入规则会同时触发。

综上所述,目前采取的策略是移除 ExtensionHeading 扩展。

此改动需要 Halo 2.12.0 的支持。

How to test it?

在 moment 页面中输入 # 后按回车,查看是否变为标签而不是其他内容。

Which issue(s) this PR fixes:

Fixes #65

Does this PR introduce a user-facing change?

解决在编辑区域输入 # 号后变为标题而不是标签的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby February 1, 2024 08:21
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@guqing
Copy link
Member

guqing commented Apr 11, 2024

有冲突需要解决

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
Copy link

f2c-ci-robot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@ruibaby ruibaby merged commit a0436e3 into halo-sigs:main May 6, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当使用标签时输入#号后回车变成了标题而无法使用标签
3 participants