Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 1.0.1 #15

Merged
merged 2 commits into from
Apr 7, 2023
Merged

chore: release 1.0.1 #15

merged 2 commits into from
Apr 7, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 6, 2023

发布 1.0.1，修复认证方式描述不正确的问题。

None

@ruibaby
chore: release 1.0.1
411a0c9 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang April 6, 2023 14:47
guqing
guqing reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
JohnNiang
JohnNiang reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还需要修改：https://github.com/halo-sigs/plugin-oauth2/blob/86133f134c8185591a9de0bfbfecc1a5fa91391b/gradle.properties。

@ruibaby
Copy link
Member Author

ruibaby commented Apr 6, 2023

还需要修改：https://github.com/halo-sigs/plugin-oauth2/blob/86133f134c8185591a9de0bfbfecc1a5fa91391b/gradle.properties。

修改成 1.1.0-SNAPSHOT 还是 1.0.1-SNAPSHOT？

@JohnNiang
Copy link
Contributor

还需要修改：https://github.com/halo-sigs/plugin-oauth2/blob/86133f134c8185591a9de0bfbfecc1a5fa91391b/gradle.properties。

修改成 1.1.0-SNAPSHOT 还是 1.0.1-SNAPSHOT？

1.0.1-SNAPSHOT

@ruibaby
Remove version field
d4a8bf4 
Signed-off-by: Ryan Wang <i@ryanc.cc>
JohnNiang
JohnNiang approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 26a3831 into halo-sigs:main Apr 7, 2023
@ruibaby ruibaby deleted the chore/release-1.0.1 branch April 7, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruibaby @JohnNiang @guqing