initial import of Dockerfile #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halprin
requested changes
Nov 1, 2018
Dockerfile
Outdated
| # [...] are the arguments to the fcli commandFROM alpine:latest | ||
|
|
||
| # use Alpine Linux -- the resulting image is ~210mb | ||
| FROM alpine:latest |
There was a problem hiding this comment.
There is already the easy to use image python:3-alpine. https://hub.docker.com/_/python/
Check the Create a Dockerfile in your Python app project section at that link above to see a way that could easily be adapted to run fcli.
|
resolves #40 I reviewed several other Alpine-based python3 sources, including python:3-alpine and jfloff/alpine-python:3.4-slin ; unfortunately, they're even larger than the original (just pulling alpine-latest and installing the required packages). |
|
I'm not so worried about the size of the Docker image as I am about maintainability and not reinventing the wheel. |
|
set the base image back to python:3-alpine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a Dockerfile so that a container with all of the correct libraries, packages, etc. needed to run fcli could be used without reliance upon the host system's installation of Python, etc..
To build the image:
docker build -t halprin/fcli .To run the image:
docker run -v ~/.fcli:/.fcli halprin/fcli fcliThe last part of the docker run command ('fcli') is the command to run in the container; therefore, arguments passed after the 'flci' command are passed to fcli as options.
It may further be advantageous to create a shell alias to simplify running fcli; for example, consider the following:
the, one can use fcli "normally":