Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sddm wayland only #4

Merged
merged 0 commits into from
Apr 11, 2024
Merged

Sddm wayland only #4

merged 0 commits into from
Apr 11, 2024

Conversation

hamburger1984
Copy link
Owner

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 force-pushed the sddm-wayland-only branch 2 times, most recently from f9b9d91 to 51c7c88 Compare February 27, 2024 22:34
@SuperSandro2000 SuperSandro2000 force-pushed the sddm-wayland-only branch 2 times, most recently from aa4983f to 1f1bb87 Compare February 28, 2024 19:37
hamburger1984 pushed a commit that referenced this pull request Mar 1, 2024
@trofi
unnethack: disable fortify3 to avoid startup crash
a956789 
Without the change `unnethack` startup crashes as:

    (gdb) bt
    #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
    #1  0x00007f734250c0e3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
    #2  0x00007f73424bce06 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
    #3  0x00007f73424a58f5 in __GI_abort () at abort.c:79
    #4  0x00007f73424a67a1 in __libc_message (fmt=fmt@entry=0x7f734261e2f8 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
    NixOS#5  0x00007f734259b1d9 in __GI___fortify_fail (msg=msg@entry=0x7f734261e2df "buffer overflow detected") at fortify_fail.c:24
    NixOS#6  0x00007f734259ab94 in __GI___chk_fail () at chk_fail.c:28
    NixOS#7  0x00000000005b2ac5 in strcpy (__src=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)",
        __dest=0x7ffe68838990 "\001") at /nix/store/B0S2LKF593R3585038WS4JD3LYLF2WDX-glibc-2.38-44-dev/include/bits/string_fortified.h:79
    NixOS#8  curses_break_str (str=str@entry=0x7ffe68838b00 "Shall I pick a character's race, role, gender and alignment for you? [YNTQ] (y)", width=width@entry=163,
        line_num=line_num@entry=1) at ../win/curses/cursmisc.c:275
    NixOS#9  0x00000000005b3f51 in curses_character_input_dialog (prompt=prompt@entry=0x7ffe68838cf0 "Shall I pick a character's race, role, gender and alignment for you?",
        choices=choices@entry=0x7ffe68838d70 "YNTQ", def=def@entry=121) at ../win/curses/cursdial.c:211
    NixOS#10 0x00000000005b9ca0 in curses_choose_character () at ../win/curses/cursinit.c:556
    NixOS#11 0x0000000000404eb1 in main (argc=<optimized out>, argv=<optimized out>) at ./../sys/unix/unixmain.c:309

which corresponds to `gcc` warning:

    ../win/curses/cursmisc.c: In function 'curses_break_str':
    ../win/curses/cursmisc.c:275:5: warning: '__builtin___strcpy_chk' writing one too many bytes into a region of a size that depends on 'strlen' [-Wstringop-overflow=]
      275 |     strcpy(substr, str);
          |     ^

I did not find a single small upstream change that fixes it. Let's
disable `fortify3` until next release.

Closes: NixOS#292113
@hamburger1984 hamburger1984 force-pushed the andreas_on_the_edge branch 6 times, most recently from 215fd6e to fb2f889 Compare March 2, 2024 12:24
@hamburger1984 hamburger1984 force-pushed the andreas_on_the_edge branch 9 times, most recently from 53937aa to e8f14eb Compare March 6, 2024 18:00
@hamburger1984 hamburger1984 force-pushed the andreas_on_the_edge branch 7 times, most recently from b7b7cb2 to b2af68a Compare March 18, 2024 09:23
@SuperSandro2000 SuperSandro2000 force-pushed the sddm-wayland-only branch 7 times, most recently from 8a5e8ac to 63244f1 Compare March 24, 2024 21:18
@hamburger1984 hamburger1984 force-pushed the andreas_on_the_edge branch 13 times, most recently from e6cf41a to 0b8033a Compare March 27, 2024 22:34
@SuperSandro2000 SuperSandro2000 force-pushed the sddm-wayland-only branch 3 times, most recently from 8037b49 to d3dbe49 Compare April 4, 2024 17:53
@hamburger1984 hamburger1984 force-pushed the andreas_on_the_edge branch 2 times, most recently from f2405a2 to 813d6d9 Compare April 8, 2024 18:34
@hamburger1984 hamburger1984 merged commit 4cc6ce4 into hamburger1984:andreas_on_the_edge Apr 11, 2024
7 checks passed
@SuperSandro2000 SuperSandro2000 deleted the sddm-wayland-only branch April 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamburger1984