The Update function had some problems. Now it is fine. #1
Conversation
|
Before I merge this pull request, could you explain what you have fixed? |
|
codingboy_CW I have not fixed everything but I have changed one thing. Not all CSS properties could be added and sometimes the changes couldn't come live and I changed the update() into what’s in the script.js now so that it does. I’m not sure about the body element though. Run my code to see if it’s fixed but I’m not sure. The problem was that The body{} was changing the entire HTML content as well as the test-div. |
|
I've tested the code and unfortunately it is now broken. If you could fix it so that changes are made as you type, that would be great. Note of advice: only open pull requests when you are sure what you have added works :) |
|
Unfortunately the same is happening with yours. I will update the code again, but originally it hasn't been working. Uploading codingboy_CW - Live CSS Editor! and 2 more pages - Work - Microsoft Edge 2023-04-13 19-13-25.mp4… |
|
Really? Strange ... it seems to be working for me and others - check your system to make sure everything is fine. |
|
Actually, I tested it on many different devices, same thing. |
|
Can you describe exactly what the issue you're facing is? And how you've fixed that in this PR too - that will help me debug the issue. |
|
Also, which devices did you test on? |
|
Confidential - sorry, but I can tell you some devices: |
|
The live CSS editor; the changes aren't coming live. Sometimes it works with many bugs. Also the body{} changes the whole HTML content, instead of the .test-div. |
|
The body { } is purposefully there to modify the whole website, and .test-div { } is there to just modify the div. Also, please specify which of the 'many bugs' you are talking about so I can look into things and fix the issue. The live system should work though; could you explain how often the changes take effect? |
|
For me - never. |
|
Ok, since the issue seems to only be on your side and this PR breaks it fully, I can't merge this pull request until the issues on your side are fixed. Sorry 😔 |
|
What? This pr is fully functional, check again - you may have put something wrong |
|
And by the way - no, its not just for me. Im getting issues with multiple devices, different places, checked all the settings, scanned the network, and everything was fine. It has to be an issue with this. |
I meant with other people. Also please send a video showing the issue you're getting on the website |
|
Your PR seems to be working - can you send a video of the website not working so I can see how this pull request fixes the issue |
Yeah, thats also what Im saying. |
|
Can I see the video? |
|
Wait a sec |
|
The file size max limit is too small-sorry(10MB) |
|
Email me at codingboy.cw@gmail.com |
|
Please check your inbox |
|
Do you have any logs at all to shed some light as to what is going on? Try checking Chrome DevTools with F12 to see if you spot anything at all. |
|
|
Maybe my solution is better |
This was my plan: The way CSS was being applied: I tried using the style property of the DOM elements to directly modify their CSS styles, which allowed me to modify the styles of individual elements on the page without replacing the entire content of the style element. The update() function: I made the update() function to apply the CSS changes to individual elements on the page rather than replacing the entire style element. I also added a check to create a style element if one did not exist. |
|
Right ok, I'll add these changes in - thanks! |
|
So are you going to merge the pr |
No description provided.