RFC: support for nested usage of iterrr: macro and support for custom ident with opname: syntax
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n have side effects
|
You did it man! please add the description in |
hamidb80
approved these changes
Dec 6, 2022
|
I will update the PR with changes to the README. |
|
This PR could be squashed down to 3 commits: Nim 1.7.x fix, syntax changes, and readme updates. |
hamidb80
reviewed
Dec 6, 2022
…nt with 'opname:' syntax
|
Fixed readme and squashed PR into 3 commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the fix for Nim 1.7.x the other two commits implement:
iterrr:macroopname:syntaxI am sure these changes can be improved but before putting more work into them if this is going in an acceptable direction. Comments?