Haml 6 Support #180
Merged
Haml 6 Support #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BilalBudhani Thanks! |
|
@indirect I tried to release a new gem with this update, but turned out that I do not have permission to push this gem. Could you either add me to the gem owners or publish a new release? Thank you in advance! |
|
@amatsuda sorry about that! I’ve invited you to be an owner. |
|
@indirect Thank you very much! @BilalBudhani Just made a new gem release versioned 2.1.0 with this change. Thanks! |
|
Should this have resulted in a major version change for haml-rails? Upgrading to haml 6 broke some of ours views that still relied on the haml rails helpers that were available in 5.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables upgrading to newly released Haml 6 https://github.com/haml/haml/releases/tag/v6.0.0