Feat: Schema Instances #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 29, 2021 16:03
The implementation of state in this component is incorrect and unnecessary. I have removed it here for simplicity of component state management upstream from this component.
This commit includes a new component event handler "handleUpdate".
It is intended to be passed to button "onClick" events that would
allow a menu to be configured to load a different schema for each button.
example:
```
// a Button component definition that accepts an "onClick" event handler
const Button = ({ name, value, onClick }) => <button type="button" value={value} onClick={onClick}>{name}</button>;
// an instance of Button
<Button name="component" value="component" onClick={handleUpdate} />
```
Implements the React Router module to allow a single React component to route to the various schema definition sections. The page remains the same each time, but using URL queries for the type and instance of a schema, the content is re-rendered with the appropriate data tables.
RossMurr4y
added
documentation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hamlet/hamlet-docs/of73z010j |
|
Converted back to draft whilst I investigate why local hosting works, but app build does not. |
added 9 commits
February 8, 2021 12:03
|
Builds now passing correctly. PR ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor reference data pages into one page, rendering only the chosen Schema Type/Instance. Deep linking is supported by way of URL query parameters i.e
https://docs.hamlet.io/reference?type=component&instance=baselineTo test, run locally and visit : http://localhost:3000/reference
Addresses:
Closes #57
Closes #58
Closes #59
Closes #60
Closes #61
Target Audience
Types of changes
Documentation
Site Design
Followup Actions
apigatewayonce Feature - Composite Object AttributeSet Attribute engine#1502 is merged (schema won't generate until then due to a merge of new content ahead of this dependency)Checklist:
hamlet roadmapproject.