feat: Manual Account Creation, Create Transaction Behavior, and Documentation Updates #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hammem
approved these changes
Jan 9, 2024
Comment on lines
+292
to
+293
| "type": account_type, | ||
| "subtype": account_sub_type, |
There was a problem hiding this comment.
What happens if these are invalid? Should the code pull the types implicitly and check them for folks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
feat: Introduces
create_manual_accountandget_account_type_optionsto facilitate the creation of a new manual account within MonarchMoney.create_manual_accountallows users to create a manual account with specific attributes.get_account_type_optionsprovides available account types and their subtypes for reference during account creation.feat: Updated the behavior of
create_transaction. Previously, new transactions would automatically update the account's balance. But a recent change in MonarchMoney added aupdate_balancefield which defaults to false. This updatescreate_transcationto use the new field whether the transaction should update the account balance or not.docs: fixed spelling and added new methods