Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify grouping logic in count functions #35

Open
tavinathanson opened this issue May 17, 2016 · 2 comments
Open

Verify grouping logic in count functions #35

tavinathanson opened this issue May 17, 2016 · 2 comments

Comments

@tavinathanson
Copy link
Member

We've often run into trouble with different de-duping mechanisms prior to grouping variants, epitopes, etc. This should be better tested.
@arahuja
Copy link
Contributor

arahuja commented May 27, 2016

Are there issues here to be aware of or is this just saying errors are possible?

@tavinathanson
Copy link
Member Author

The latter; I didn't think too hard about the exact grouping mechanisms for each count, and I know different grouping/de-dup'ing strategies have gotten us into trouble before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tavinathanson @arahuja