Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible memory leak when service is running #24

Closed
tylermzeller opened this issue May 4, 2017 · 3 comments · Fixed by #26
Closed

Possible memory leak when service is running #24

tylermzeller opened this issue May 4, 2017 · 3 comments · Fixed by #26
Labels
android bug

Comments

@tylermzeller
Copy link
Collaborator

Steps to reproduce:

  • Open up client, and make sure service is running

  • Make sure server is not running. If it is, close it down to ensure no processing on the client is happening.

  • Open the Android monitor and select the crowd-ml:datasend process. View the allocated memory continuously increasing in the performance profiler.

This may be due to the wifi listener, because that is the only running thread in the :datasend process.
@3ygun
Copy link
Collaborator

3ygun commented May 9, 2017

Is this in the tensorflow branch?

@tylermzeller
Copy link
Collaborator Author

No, I can view it on master.

@3ygun
Copy link
Collaborator

3ygun commented May 9, 2017

Was able to reproduce.

@3ygun 3ygun mentioned this issue May 10, 2017
Closed
3ygun added a commit that referenced this issue May 10, 2017
@3ygun
Changed WiFi connection listening to Event based
3d37c5e 
Following the https://stackoverflow.com/questions/1783117/network-listener-android and https://developer.android.com/reference/android/net/ConnectivityManager.html I changed from the custom WiFi ready code to an event listener one. Appears to work tested turning on and off the WiFi on my phone and the app didn't crash and was able to resume calculations. Also seems to resolve #24
@3ygun 3ygun mentioned this issue May 10, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed WiFi connection detection to Event Based Listener hammlab/Crowd-ML
2 participants
@3ygun @tylermzeller