-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new command to combine all the svgs into a single svg file #35
Comments
It is probably possible yes, you're thinking that each flag will be identified by an ID tag in a single SVG then? |
@hjnilsson that is correct. // usage: if we had a single flags.svg
<mat-icon svgIcon="ca"></mat-icon>
<mat-icon svgIcon="us"></mat-icon> Here you see how Angular material is used to register multiple flags svg(s) vs. a single icon svg (mdi.svg). Sadly, one trip to the backend is required for each svg. |
There are lots of tools that take separate images and combines them to create a single sprite. Rather than re-create that work here, just use google to find one of the tools. Here's one example: https://github.com/svg-sprite/svg-sprite |
OK, there are tools to handle this. I linked to one. Google for others. |
duplicate of #13 |
partially completed in this PR - Anyone want to fix it? #122 |
The code was broken (on Windows at the very least). Also, there's limited applicability for this code. Rather than creating specialized scripts that will likely break (I'm not going to maintain it), just use generalized open source projects that already accomplish what you're looking for (see above) |
Angular menu loads each icon individually and if service worker is not enabled, that is one call per country to the backend. It is so slow.
I am wondering if it is possible to do something like mdi, where they allow a single svg file for all the icons.
This way, there would be a single call to the backend to fetch all the flags.
Something like:
The text was updated successfully, but these errors were encountered: