ecs-run-task: Support task overrides #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdoFoco
force-pushed
the
ecs-run-task/support-task-override
branch
from
cfe2d66
to
547fd4b
Compare
hamstah
requested changes
Jan 18, 2024
ecs/run-task/main.go
Outdated
| common.FatalOnError(err) | ||
| } | ||
|
|
||
| func resolveTaskOverride(taskOverridesJSON *string) (*ecs.TaskOverride, error) { | ||
|
|
There was a problem hiding this comment.
nitpick can you remove the empty line?
ecs/run-task/main.go
Outdated
|
|
||
| func resolveTaskOverride(taskOverridesJSON *string) (*ecs.TaskOverride, error) { | ||
|
|
||
| if *taskOverridesJSON == "" { |
There was a problem hiding this comment.
instead of passing the pointer to the function, de-reference it in the main and pass it as string. From the main scope we know it's safe to de-reference it, but from the function itself it's not obvious so that line looks unsafe.
ecs/run-task/main.go
Outdated
| @@ -21,10 +25,36 @@ func main() { | |||
|
|
|||
| ecsClient := ecs.New(session, conf) | |||
|
|
|||
| taskOverride, overridesErr := resolveTaskOverride(taskOverrideJSON) | |||
There was a problem hiding this comment.
rename to err and change like 31 to = instead of :=
ecs/run-task/main.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| var taskOverride *ecs.TaskOverride |
There was a problem hiding this comment.
you can simplify
taskOverride := &ecs.TaskOverride{}
ecs/run-task/main.go
Outdated
|
|
||
| var taskOverride *ecs.TaskOverride | ||
| taskOverride = &ecs.TaskOverride{} | ||
| err = json.Unmarshal(b, taskOverride) |
There was a problem hiding this comment.
if err := err = json.Unmarshal(b, taskOverride); err != nil {
return nil, err
}
7101cb9
to
dd68fa2
Compare
hamstah
requested changes
Jan 23, 2024
ecs/run-task/main.go
Outdated
| cluster = kingpin.Flag("cluster", "ECS cluster").Required().String() | ||
| taskDefinition = kingpin.Flag("task-definition", "ECS task definition").Required().String() | ||
| cluster = kingpin.Flag("cluster", "ECS cluster").Required().String() | ||
| taskOverrideJSON = kingpin.Flag("task-override-json", "Path to a JSON file with the task override to use").String() |
There was a problem hiding this comment.
sorry I missed it in the previous review, can you rename to overrides (with s) to be consistent with the AWS argument?
ecs/run-task/main.go
Outdated
| @@ -21,10 +25,33 @@ func main() { | |||
|
|
|||
| ecsClient := ecs.New(session, conf) | |||
|
|
|||
| _, err := ecsClient.RunTask(&ecs.RunTaskInput{ | |||
| taskOverride, err := resolveTaskOverride(*taskOverrideJSON) | |||
EdoFoco
force-pushed
the
ecs-run-task/support-task-override
branch
from
dd68fa2
to
e935af4
Compare
hamstah
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding task overrides to ecs-run-task by specifying the path to the overrides JSON file.