Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore slice names in public asset dirs #141

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

timriley
Copy link
Member

@timriley timriley commented Feb 21, 2024

This will avoid naming collisions with ordinary user-controlled files or directories.

Uses the new Hanami::Assets.public_assets_dir method introduced in hanami/assets#140.

This will avoid naming collisions with ordinary user-controlled files or directories.
@timriley timriley added this to the v2.1.0 milestone Feb 21, 2024
@timriley timriley self-assigned this Feb 21, 2024
@timriley timriley merged commit de87bb2 into main Feb 21, 2024
9 checks passed
@timriley timriley deleted the use-underscored-public-asset-dirs branch February 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant