Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify dev vs server in command descriptions #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cllns
Copy link
Member

@cllns cllns commented Mar 7, 2024

It's hard to condense the distinction down to just a handful of words, so feel free to tweak.

I also wonder if we should combine the commands somehow, since the distinction here between dev and server isn't intuitive, though I understand how they came to be, of course.

Maybe just hanami dev does the following:

  • Does Procfile.dev exist?
    • Yes
      • Does it only have this in it: web: bundle exec hanami server?
        • Yes: Start Rack::Server
        • No: Run foreman
    • No: Start Rack::Server

And then add a flag like hanami dev --ruby to just start Rack::Server if that's needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant