Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt component generator to new command defaults #162

Merged

Conversation

krzykamil
Copy link
Contributor

This adapts to https://github.com/hanami/cli/pull/137/files which was created after I created #130 but merged before it. My branch wasn't rebased before merge and since it was new files, there was no conflict.

This change simply adapts to what the parent object does now withi default initialize params.

@timriley timriley merged commit fe04357 into hanami:main Jun 7, 2024
@timriley
Copy link
Member

timriley commented Jun 7, 2024

Thanks @krzykamil, nice work figuring this out!

@timriley timriley assigned timriley and krzykamil and unassigned timriley Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants