Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .keep file for app/relations, reorder expectations #192

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

cllns
Copy link
Member

@cllns cllns commented Jul 8, 2024

Clean up for #180. I realized I missed adding app/relations/.keep, so this does that.

I also:

  • moved around some expectations so they're grouped logically with their base class
  • added a missing expectation for app/actions/.keep
  • changed how app/repos/.keep and app/structs/.keep are generated so their creation message is printed

Fixes #190, fixes #191

@cllns cllns requested a review from timriley July 8, 2024 22:49
@cllns cllns linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cllns! Just one question for you, otherwise this is good to merge :)

fs.write("app/structs/.keep", t("keep.erb", context))

fs.write("config/db/migrate/.keep" , t("keep.erb", context))
fs.write("db/.keep" , t("keep.erb", context))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only create db if we have --database=sqlite selected for the database. Is that a thing we do yet?

If it's not, then that's fine to leave here for now, but we should add another ticket to make sure we support hanami new with --database

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good call. Yea we have that, so I fixed this, and verified it works as desired for sqlite and non-sqlite.

@cllns cllns merged commit af38319 into main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hanami new should generate db/.keep when sqlite used hanami new should generate relations/.keep
2 participants