Add .keep file for app/relations, reorder expectations #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
approved these changes
Jul 9, 2024
lib/hanami/cli/generators/gem/app.rb
Outdated
| fs.write("app/structs/.keep", t("keep.erb", context)) | ||
|
|
||
| fs.write("config/db/migrate/.keep" , t("keep.erb", context)) | ||
| fs.write("db/.keep" , t("keep.erb", context)) |
There was a problem hiding this comment.
We should only create db if we have --database=sqlite selected for the database. Is that a thing we do yet?
If it's not, then that's fine to leave here for now, but we should add another ticket to make sure we support hanami new with --database
There was a problem hiding this comment.
Oh good call. Yea we have that, so I fixed this, and verified it works as desired for sqlite and non-sqlite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up for #180. I realized I missed adding
app/relations/.keep, so this does that.I also:
app/actions/.keepapp/repos/.keepandapp/structs/.keepare generated so their creation message is printedFixes #190, fixes #191