Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constants used in generators #193

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

krzykamil
Copy link
Contributor

Based on #130 (comment) I moved the constants commonly used in all generators to a common place. This also required a simple change to one of the context classes, as it was using OFFSET that was an integer, instead of the one that is an alias to INDENTATION and work better with multiplication in the code that generates the spacing in end files.

@timriley timriley assigned timriley and cllns and unassigned timriley Jul 9, 2024
@cllns
Copy link
Member

cllns commented Jul 11, 2024

Thanks @krzykamil! I felt bad about copying them yet again when I did Operation generator, so I'm glad this finally got done :)

@cllns cllns merged commit 504a060 into hanami:main Jul 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants