Generate repo #200
Merged
Generate repo #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding new templates for un-nested operations
This reverts commit a5bd2f3.
timriley
approved these changes
Jul 14, 2024
| normalized_name = if name.end_with?("_repo") | ||
| name | ||
| else | ||
| "#{inflector.pluralize(name)}_repo" |
There was a problem hiding this comment.
I love the idea of us providing the combination of convenience and guard rails through our arg handling!
Suggested change
| "#{inflector.pluralize(name)}_repo" | |
| "#{inflector.singularize(name)}_repo" |
Just one adjustment though: repos are actually named singularly, so BookRepo, not BooksRepo.
| else | ||
| "#{inflector.pluralize(name)}_repo" | ||
| end | ||
| slice = inflector.underscore(Shellwords.shellescape(slice)) if slice |
There was a problem hiding this comment.
TBH, I don't think we need to shellescape this slice arg at all. We're checking for the presence of the slice dir via our generators anyway, so that's validation enough for the slice name.
In #201 I removed the shellescaping, and I reckon we could just do the same here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on work done in #199. This is where those refactors pay off: this almost trivial PR to add a repo generator.
I decided to add some logic for
pluralization(update:) singularization:hanami g repo book=> BookRepohanami g repo books=> BookRepohanami g repo books_repo=> BooksRepohanami g repo book_repo=> BookRepoThe idea here is that we want to guide people to naming things with our convention, but if they end their name with _repo then we assume they're doing it intentionally and want that exact name, without any singularization.
Closes #189