Fix redundant name arg in generate commands #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our recently updated
generate
subcommands are using a newCommands::App::Generate::Command
base class, which hadargument :name
defined.However, many of these subclasses also had their own
argument :name
defined too, which led to these commands expecting two name arguments to be given, which is incorrect.I've fixed this by removing the
argument :name
from the base class, since having this in the subclasses allows them to provide their own specificdesc:
help text. After this change, commands likegenerate relation create_posts
work again.