Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant name arg in generate commands #208

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

timriley
Copy link
Member

@timriley timriley commented Jul 16, 2024

Our recently updated generate subcommands are using a new Commands::App::Generate::Command base class, which had argument :name defined.

However, many of these subclasses also had their own argument :name defined too, which led to these commands expecting two name arguments to be given, which is incorrect.

I've fixed this by removing the argument :name from the base class, since having this in the subclasses allows them to provide their own specific desc: help text. After this change, commands like generate relation create_posts work again.

@timriley
Copy link
Member Author

cc @cllns

@timriley timriley self-assigned this Jul 16, 2024
@timriley timriley changed the title Fix redundant name arg from generate commands Fix redundant name arg in generate commands Jul 16, 2024
@timriley timriley merged commit 61373ae into main Jul 16, 2024
9 checks passed
@timriley timriley deleted the fix-redundant-name-argument-for-generate-commands branch July 16, 2024 10:24
@cllns
Copy link
Member

cllns commented Jul 16, 2024

Ah, sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants