Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip-route flag for action and slice generators #227

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

kyleplump
Copy link
Contributor

closes #196

i tried to mirror the existing implementation of the other flags, even if we ended up with goofy functions like Generators::App::Action#generate_route?

lmk if you'd like to see any changes, thanks!

@timriley
Copy link
Member

The changes here look great, @kyleplump! ❤️ Could you please include one test case for the action + slice generators for when skip_route is passed? After that I think we can get this in!

@kyleplump
Copy link
Contributor Author

thanks @timriley! i've included the tests for your review. lmk if this works

@timriley timriley changed the title flags for skipping route generation for both action/slice Add --skip-route flag for action and slice generators Oct 19, 2024
@timriley timriley merged commit 34b0489 into hanami:main Oct 19, 2024
@timriley
Copy link
Member

Thanks @kyleplump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --skip-route option to generate action command
2 participants