Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue trying to generate migration at / #233

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

timriley
Copy link
Member

When a "" base path element (which we use for app migrations) is given to fs.join, it will convert it into a leading /, which means we were attempting to write a migration into the root of the filesystem, instead of into the current working directory (i.e. the root of the app).

When a `””` path (which we do for app migrations) is given to `fs.join`, it will convert it into a leading `/`, which means we were attempting to write a migration into the root of the filesystem!
@timriley timriley merged commit e2cc23a into main Sep 23, 2024
9 checks passed
@timriley timriley deleted the fix-generate-migration branch September 23, 2024 11:05
@timriley timriley self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant