Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor settings logic #50

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Refactor settings logic #50

merged 3 commits into from
Feb 19, 2018

Conversation

davydovanton
Copy link
Member

No description provided.

@davydovanton davydovanton self-assigned this Feb 19, 2018
@davydovanton
Copy link
Member Author

@GustavoCaso maybe it will interesting for you.

  • I changed repository method, now it always return entity object (nil object pattern). After that I dropped some conditions from actions;
  • admin/settings page now shows settings history with all settings values and time when it was changed

@davydovanton davydovanton merged commit ab151c0 into master Feb 19, 2018
@davydovanton davydovanton deleted the chore/refactor-settings branch February 19, 2018 12:36
@GustavoCaso
Copy link
Member

GustavoCaso commented Feb 19, 2018 •
edited
Loading

@davydovanton fantastic work now is much better than before ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davydovanton davydovanton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davydovanton @GustavoCaso