Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for services #9

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Conversation

artofhuman
Copy link
Contributor

Part of #3

Copy link
Member

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Thanks for adding vcr 👍

Could you fix my issue before merge?

README.md Outdated
@@ -1,4 +1,4 @@
# Hanami contributors
# Hanami contributors [![Build Status](https://travis-ci.org/hanami/contributors.svg?branch=master)](https://travis-ci.org/hanami/contributors)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you drop this line? I'll add travis status later 👍

@artofhuman
Copy link
Contributor Author

Done

@davydovanton
Copy link
Member

thank you so much 💛

@davydovanton davydovanton merged commit 9d007a9 into hanami:master Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants