Allow asset path configuration #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlentwistle
commented
Jul 31, 2014
karlentwistle
commented
- provide a way to allow developers to configure asset paths
* provide a way to allow developers to configure asset paths
|
#62 but on a branch not master |
| end | ||
|
|
||
| def to_s | ||
| @path.to_s | ||
| @paths.first.to_s |
There was a problem hiding this comment.
This is my sticking point at the moment, hence still WIP
* Introduced the concept of the Asset Path
|
Turns out you can use multiple Rack::Static middlewares in the same app 👍 |
karlentwistle
changed the title
added 2 commits
August 1, 2014 11:01
Giving the collaboration fixture an additional asset path in addition to its default /public path. Checking that we can retrieve the file
karlentwistle
changed the title
karlentwistle
changed the title
TryStatic will probe Rack::Static to see if a file is found.
* Needed to implement an equality operator on Assets::Path
| @@ -4,6 +4,23 @@ module Lotus | |||
| # @since 0.1.0 | |||
| # @api private | |||
| class Middleware | |||
| class TryStatic | |||
There was a problem hiding this comment.
😱 I don't think this is a good idea at all, because it adds a potential overhead for each HTTP request related to assets.
|
@karlentwistle what's the status of this PR? Why did you close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.