-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow asset path configuration #63
Conversation
karlentwistle
commented
Jul 31, 2014
- provide a way to allow developers to configure asset paths
* provide a way to allow developers to configure asset paths
#62 but on a branch not master |
end | ||
|
||
def to_s | ||
@path.to_s | ||
@paths.first.to_s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my sticking point at the moment, hence still WIP
* Introduced the concept of the Asset Path
Turns out you can use multiple Rack::Static middlewares in the same app 👍 |
Giving the collaboration fixture an additional asset path in addition to its default /public path. Checking that we can retrieve the file
TryStatic will probe Rack::Static to see if a file is found.
* Needed to implement an equality operator on Assets::Path
@@ -4,6 +4,23 @@ module Lotus | |||
# @since 0.1.0 | |||
# @api private | |||
class Middleware | |||
class TryStatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱 I don't think this is a good idea at all, because it adds a potential overhead for each HTTP request related to assets.
@karlentwistle what's the status of this PR? Why did you close it? |