HTML escape #51
Merged
HTML escape #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 84e3bae on html-escape into * on master*. |
|
Changes Unknown when pulling cace05a on html-escape into * on master*. |
|
Looks great, and easy enough to follow... |
| # @since x.x.x | ||
| # @api private | ||
| # | ||
| # @see http://www.ruby-doc.org/Fixnum.html#method-i-to_s |
There was a problem hiding this comment.
Page not found, the message in the web:
We're sorry, but that page cannot be found.
There was a problem hiding this comment.
@AlfonsoUceda Fixed, thanks 👍
|
👍 @jodosha I learn a lot reading your code ;) and tomorrow I'll see the references posted above. |
|
Changes Unknown when pulling f5fc4cc on html-escape into * on master*. |
|
Changes Unknown when pulling bc940ba on html-escape into * on master*. |
|
Changes Unknown when pulling d9225cb on html-escape into * on master*. |
…et devs to mark a string as safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Escape utilities for HTML contents and attributes
HTML escape utilities
Based on OWASP research and OWASP ESAPI code
See:
https://www.owasp.org
https://www.owasp.org/index.php/Cross-site_Scripting_%28XSS%29
https://www.owasp.org/index.php/XSS_(Cross_Site_Scripting)_Prevention_Cheat_Sheet
https://www.owasp.org/index.php/ESAPI
https://github.com/ESAPI/esapi-java-legacy
Ref: hanami/helpers#7
Technical notes
Lookup chars
It internally uses Hash instances to lookup chars.
They are implemented with this syntax
{ 0x9f => true }, which makes them equivalent toSet.new([0x9f]), but the lookup is faster: https://gist.github.com/jodosha/ac5dd54416de744b9600Output class
The output is a
Lotus::Utils::Escape::SafeStringinstance. This is a private class that is required for two reasons:Lotus::Helperscompatibility)#rawinLotus::VieworLotus::Helpers)