Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace .boxplot()with .plot.box() #256

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Jan 30, 2023

Replacing df.groupby('split').boxplot() with df.groupby('split').plot.box() in tests/test_weighted_pandas.py::test_BoxPlot() seems to avoid the problem where the plots in the later test_AreaPlot() non-deterministically believe their axes to be shared, which prevents them from setting the lower y limit to 0. The original tests only fail when this happens to only one of the two.

Seeing as this is occurring for unmodified pandas.DataFrames, I don't think this is something we can fix easily in anesthetic

  • Check that this doesn't reduce coverage
  • @williamjameshandley @lukashergt do you think it's appropriate to explicitly check that the lower y limit is 0? (they do not)

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #256 (09d6cfb) into master (67b9a96) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #256   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         2422      2422           
=========================================
  Hits          2422      2422           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@williamjameshandley
Copy link
Collaborator

Let's see if this fixes the default in the next few PRs. Please squash and merge

@AdamOrmondroyd AdamOrmondroyd merged commit 0aeaded into handley-lab:master Feb 7, 2023
@williamjameshandley williamjameshandley mentioned this pull request Jun 28, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants