Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to fix
hsk_chain_maybe_sync
. When this function is called the first time, it setschain->synced = true
. So all sync checking logic afterwards gets skipped:hnsd/src/chain.c
Lines 265 to 269 in cf19505
If you were wondering why you see this in the logs it's because of that ^.
I think this was just old code before mainnet launch. After removing it, hnsd will refuse to answer requests until it's fully synced which is neat! Answering queries without waiting to sync is problematic due to cache poisoning from old records ... etc. Fingertip mitigates that by trying to guess the synced state but hnsd should ideally do it.