Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: add 'spendable_balance' to getwalletinfo RPC #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wallet: add 'spendable_balance' to getwalletinfo RPC #507

wants to merge 1 commit into from

Conversation

ca98am79
Copy link
Contributor

This enables a user to view their spendable balance using the getwalletinfo RPC

@coveralls
Copy link

coveralls commented Aug 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 232854351

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 59.161%
Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
Totals Coverage Status
Change from base Build 212167982: 0.8%
Covered Lines: 19359
Relevant Lines: 30452
💛 - Coveralls

@pinheadmz pinheadmz mentioned this pull request Jan 27, 2021
Closed
@ca98am79 ca98am79 mentioned this pull request Nov 18, 2021
Open
@nodech nodech added tests part of the codebase wallet-rpc part of the codebase patch Release version labels Dec 9, 2021
@nodech
Copy link
Contributor

nodech commented Dec 9, 2021

I am wondering if we should modify this and/or add getbalancedetails(or info) rpc methods to include balance details which can be used by users however they want. It could be advanced version of getbalance.

@pinheadmz
Copy link
Member

I am wondering if we should modify this and/or add getbalancedetails(or info) rpc methods to include balance details which can be used by users however they want. It could be advanced version of getbalance.

Bitcoin core has extra details in getwalletinfo and also has separate rpc getwalletbalances which also calculates the immature newly mined coins (see #662)

@nodech nodech added the quick review difficulty - easy label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Release version quick review difficulty - easy tests part of the codebase wallet-rpc part of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ca98am79 @coveralls @nodech @pinheadmz