Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool invalidate claims when period ends. #813

Merged
merged 2 commits into from
May 29, 2023

Conversation

nodech
Copy link
Contributor

@nodech nodech commented May 24, 2023

Claims if they get ignored in the claimPeriod - 1 block and still are part the mempool - next block will be invalid as it will include claims (as they are in mempool).

This invalidates claims in the mempool.

@nodech nodech added mempool part of the codebase mining part of the codebase intermediate review difficulty - intermediate labels May 24, 2023
@nodech nodech force-pushed the mempool-claim-invalidation branch 2 times, most recently from 5131c7f to 81a46d9 Compare May 24, 2023 16:42
@nodech nodech added the patch Release version label May 24, 2023
@nodech nodech force-pushed the mempool-claim-invalidation branch from 81a46d9 to 7f0357b Compare May 24, 2023 17:27
@coveralls
Copy link

coveralls commented May 24, 2023

Coverage Status

Coverage: 68.479% (+0.04%) from 68.44% when pulling d8539c4 on nodech:mempool-claim-invalidation into 2bb8f0b on handshake-org:master.

@nodech nodech requested a review from rithvikvibhu May 24, 2023 20:06
lib/mempool/mempool.js Show resolved Hide resolved
@nodech nodech force-pushed the mempool-claim-invalidation branch from d8539c4 to f857df5 Compare May 29, 2023 10:16
@nodech nodech merged commit 614bfaf into handshake-org:master May 29, 2023
@nodech nodech deleted the mempool-claim-invalidation branch June 18, 2023 09:04
This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intermediate review difficulty - intermediate mempool part of the codebase mining part of the codebase patch Release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants