Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty-printer writes extra break at end #5

Closed
talex5 opened this issue Sep 4, 2019 · 2 comments
Closed

Pretty-printer writes extra break at end #5

talex5 opened this issue Sep 4, 2019 · 2 comments

Comments

@talex5
Copy link

talex5 commented Sep 4, 2019

This makes it hard to use. e.g.

#require "duration";;
#require "fmt";;
Fmt.pr "Timeout (%a) expired" Duration.pp (Duration.of_min 5);;

prints

Timeout (5 minutes
) expired
@hannesm
Copy link
Owner

hannesm commented Sep 4, 2019

thanks for the report, would you mind to try whether the pp branch (see #6) fixes the issue for you satisfactory?

@hannesm
Copy link
Owner

hannesm commented Sep 4, 2019

also, when using Format, it is advisable to open a box, i.e. Fmt.pr "@[Timeout (%a) expired@]" Duration.pp 23000000001L

hannesm added a commit that referenced this issue Oct 26, 2019
don't emit extra space at end, fix #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants