using testcontaines in dev mode #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rajadilipkolli Thanks for sending this PR to demonstrate the new features. I also tried them in my spring6-sandbox, I am still confused in some config, spring-projects/spring-boot#35824 For this PR, can you do a simple refactoring on it, keep the original Repository tests there, and add a new RepositoryTest for the new feature. |
hantsy
requested changes
Jun 15, 2023
| @ActiveProfiles("test") | ||
| @Import(TestDemoApplication.class) |
There was a problem hiding this comment.
We can specify the class attribute of @SpringBootTest instead of @Import here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.