Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api. Support PhysxCollisionShapePlane conversion #83

Merged
merged 37 commits into from
Apr 16, 2024
Merged

Conversation

KolinGuo
Copy link
Member

No description provided.

* Remove ArticulatedModel::setName
* Add FCLModel::getName
* PlanningWorld::collide() => PlanningWorld::isStateColliding()
* PlanningWorld::selfCollide() => PlanningWorld::checkSelfCollision()
* PlanningWorld::collideWithOthers() =>
PlanningWorld::checkRobotCollision()
* PlanningWorld::collideFull() => PlanningWorld::checkCollision()
* PlanningWorld::distance() => PlanningWorld::distanceToCollision()
* PlanningWorld::distanceOthers() => PlanningWorld::distanceRobot()
* PlanningWorld::distanceFull() => PlanningWorld::distance()
* FCLModel::collideFull() => FCLModel::checkSelfCollision()
* FCLModel::collide() => FCLModel::isStateColliding()
* Change FCLModel::collideFull() default from GJKSolverType::GST_INDEP
to GJKSolverType::GST_LIBCCD
* Update fcl_model name when articulated_model's name is overridden
Between two instances of PhysxArticulation or Entity
* Planner.plan_qpos_to_qpos => Planner.plan_qpos
* Planner.plan_qpos_to_pose => Planner.plan_pose
@KolinGuo KolinGuo requested a review from Lexseal April 15, 2024 22:58
Copy link
Collaborator

@Lexseal Lexseal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the srdf/urdf handling needs some changes. Other than that, still need to fix all the tests and try out the new APIs

mplib/urdf_utils.py Outdated Show resolved Hide resolved
mplib/urdf_utils.py Show resolved Hide resolved
pybind/core/pybind_articulated_model.cpp Show resolved Hide resolved
src/collision_detection/fcl/fcl_model.cpp Show resolved Hide resolved
src/collision_detection/fcl/fcl_model.cpp Show resolved Hide resolved
mplib/planner.py Outdated Show resolved Hide resolved
mplib/urdf_utils.py Show resolved Hide resolved
@KolinGuo KolinGuo force-pushed the update_api branch 2 times, most recently from 6675b10 to f61a00f Compare April 16, 2024 21:18
@KolinGuo KolinGuo merged commit b1b88a2 into main Apr 16, 2024
9 checks passed
@KolinGuo KolinGuo deleted the update_api branch April 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants