Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86 Fix thermostat for ios13 #87

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Oct 3, 2019

set target temperature is not working in ios13 as ios13 expected temperature unit (celsius, fahrenheit) to be changeable. the temperature unit is used in homekit only for displaying purposes. at the protocol level the celsius is used as basis.

this patch makes temperature unit changeable.

@ccutrer
Copy link
Collaborator

ccutrer commented Oct 3, 2019

I can confirm that this fixed my thermostat with ios13

@amedeomantica
Copy link

+1

@ccutrer ccutrer merged commit 58d068a into hap-java:master Oct 17, 2019
@yfre yfre deleted the fix_thermostat_for_io13 branch May 5, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants