Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate include statements for JPA #3331

Merged
merged 3 commits into from Jan 26, 2022
Merged

Conversation

jamesagnew
Copy link
Collaborator

Include startements in the JPA server cause a JPA exception. We need to validate them before it gets to that.

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #3331 (34fa24b) into master (31bb1d9) will increase coverage by 0.01%.
The diff coverage is 92.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3331      +/-   ##
============================================
+ Coverage     82.80%   82.82%   +0.01%     
- Complexity    20460    20476      +16     
============================================
  Files          1367     1367              
  Lines         73521    73553      +32     
  Branches      11053    11055       +2     
============================================
+ Hits          60882    60921      +39     
+ Misses         8390     8385       -5     
+ Partials       4249     4247       -2     
Impacted Files Coverage Δ
.../src/main/java/ca/uhn/fhir/rest/api/Constants.java 100.00% <ø> (ø)
...a/ca/uhn/fhir/rest/api/server/IBundleProvider.java 95.00% <ø> (ø)
.../uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java 91.84% <90.66%> (+0.32%) ⬆️
...e/src/main/java/ca/uhn/fhir/model/api/Include.java 76.92% <100.00%> (+2.53%) ⬆️
.../uhn/fhir/jpa/term/TermDeferredStorageSvcImpl.java 89.20% <0.00%> (-0.94%) ⬇️
.../ca/uhn/fhir/jpa/search/builder/SearchBuilder.java 85.75% <0.00%> (-0.27%) ⬇️
...or/TransactionConcurrencySemaphoreInterceptor.java 85.29% <0.00%> (+1.47%) ⬆️
...r/UserRequestRetryVersionConflictsInterceptor.java 87.50% <0.00%> (+4.16%) ⬆️
...ca/uhn/fhir/jpa/dao/tx/HapiTransactionService.java 79.24% <0.00%> (+5.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bb1d9...34fa24b. Read the comment docs.

@jamesagnew jamesagnew merged commit 3f42414 into master Jan 26, 2022
@jamesagnew jamesagnew deleted the ja_20220125_validate_includes branch January 26, 2022 14:16
michaelabuckley pushed a commit that referenced this pull request Jan 31, 2022
* Validate include statements for JPA

* Add changelog

* Optmize test fix
michaelabuckley added a commit that referenced this pull request Jan 31, 2022
* master:
  Add error codes to all exceptions (#3278)
  3156 multiple tag race condition (#3297)
  Fix globbing pattern for log files
  Update instance_validator.md (#3328)
  add needed dependendencies for mysql and mssql (#3343)
  Add okhttp dep
  3335 allow alternative character encoding length in searchparam (#3336)
  Fix mdm config for single application context environment.  (#3338)
  Validate include statements for JPA (#3331)
  Add okhttp dep to r5 and indicate which deps need to be included (#3332)
  Bump RestEasy to 5.0.2 (#3329)

# Conflicts:
#	hapi-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java
#	hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
#	hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/ElasticsearchSvcImpl.java
#	hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/dstu2/FhirResourceDaoDstu2SearchNoFtTest.java
#	hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/subscription/module/matcher/InMemorySubscriptionMatcherR4Test.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant