Add error codes to all exceptions #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Exception have the message string as the second parameter
… message responses.
…r match the message responses.
…atements would better match the message response
…-20211126-error-codes # Conflicts: # pom.xml
… better match the message response
… errors which now use error codes. Also changed ResourceNotFoundException to include error codes in its messages.
Codecov Report
@@ Coverage Diff @@
## master #3278 +/- ##
============================================
- Coverage 82.84% 82.82% -0.02%
+ Complexity 20492 20489 -3
============================================
Files 1369 1371 +2
Lines 73626 73584 -42
Branches 11064 11064
============================================
- Hits 60993 60947 -46
- Misses 8378 8385 +7
+ Partials 4255 4252 -3
Continue to review full report at Codecov.
|
tadgh
approved these changes
Jan 30, 2022
michaelabuckley
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Initial design of adding exception codes to exceptions * Initial design of adding exception codes to exceptions * change int module name to string * add comment * shorten message * shorten message * added checkstyle * developing checker * completed checkstyle plugin and unit test for it * fix NPE * fix checker so it ignores throws on exceptions that aren't new * change parameter order in InvalidResponseException * accept Msg.code() in any parameter since some exceptions like MessageException have the message string as the second parameter * exclude generated files * BIG COMMIT added error codes to all exception throws * example test fix * Modified tests such that the assert statements would better match the message responses. * Modified additional tests such that the assert statements would better match the message responses. * fix test * merge master * merge master * Fourth commit of modified tests such that the assert statements would better match the message response * Changes made to modify assert statements such that they match the new errors which now use error codes. Also changed ResourceNotFoundException to include error codes in its messages. * Modified assert messages to better match new error codes * Time Zone changes DRAFT. Certain tests pass in intellij and fail during mvn install * Modified assert messages to better match new error codes * Added comments for time zone fixes. Previous commit comment on time zone fixes was incorrect. By invaliding caches, all tests on both intellij and mvn install passed. * Reverted changes on azure-pipelines.yml * updated hapi-fhir version for checkstyle module * changes to azure-pipelines.yml * changes to azure-pipelines.yml * change to pom.xml to include hapi-fhir-checkstyle in ALLMODULES * changes to azure-piplines (these changes are to be reverted after testing) * reverted changes to azure-piplines * reverted change where hapi-fhir-checkstyle was added to pom.xml (hapi-fhir) * Attempted fix on checkstyle build error * modified azure-piplines.yml to change maven repository for checkstyle build * Attempted fix on checkstyle build error * checkstyle config location change for hapi-depoloyable-pom. (will be reverted if it does not work) * attempted dependency add for hapi-depoloyable-pom. (will be reverted if it does not work) * reverted changes for hapi-deployable-pom * add javadoc * update last code * Attempted fix on checkstyle build error * Finished adding in missing error codes to pass Checkstyle checks * Test pipelining * Fixing errors and bumping version (as suggested by Gary) * Merge * Fixing Checkstyle error * Attempted fix for date error * Add error code onto assert statement * Add in a couple more error codes * Fixing assert statements * Bump to static version for dependency * Adding error code to message * Adding error codes to exceptions * Adding error codes to exceptions * Change to work with cdr branch * Update to faulty error message * Merge changes * allow checkstyle pom to deploy Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: Simon Zuccherato <simon.zuccherato@smilecdr.com> Co-authored-by: Predap <simon.zuccherato@gmail.com> Co-authored-by: Predap <46201929+Predap@users.noreply.github.com> Co-authored-by: Tadgh <garygrantgraham@gmail.com>
michaelabuckley
added a commit
that referenced
this pull request
Jan 31, 2022
* master: Add error codes to all exceptions (#3278) 3156 multiple tag race condition (#3297) Fix globbing pattern for log files Update instance_validator.md (#3328) add needed dependendencies for mysql and mssql (#3343) Add okhttp dep 3335 allow alternative character encoding length in searchparam (#3336) Fix mdm config for single application context environment. (#3338) Validate include statements for JPA (#3331) Add okhttp dep to r5 and indicate which deps need to be included (#3332) Bump RestEasy to 5.0.2 (#3329) # Conflicts: # hapi-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/ElasticsearchSvcImpl.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/dstu2/FhirResourceDaoDstu2SearchNoFtTest.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/subscription/module/matcher/InMemorySubscriptionMatcherR4Test.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT pull request to test build not for merging