3335 allow alternative character encoding length in searchparam #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadgh
requested changes
Jan 26, 2022
hapi-fhir-base/src/main/java/ca/uhn/fhir/context/phonetic/PhoneticEncoderEnum.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/context/phonetic/PhoneticEncoderWrapper.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/context/phonetic/PhoneticEncoderWrapper.java
Outdated
Show resolved
Hide resolved
...es/ca/uhn/hapi/fhir/changelog/5_7_0/3335-added-configuration-to-specify-max-code-lengths.yml
Outdated
Show resolved
Hide resolved
...es/ca/uhn/hapi/fhir/changelog/5_7_0/3335-added-configuration-to-specify-max-code-lengths.yml
Outdated
Show resolved
Hide resolved
...-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4SearchCustomSearchParamTest.java
Show resolved
Hide resolved
hapi-fhir-base/src/test/java/ca/uhn/fhir/context/phonetic/PhoneticEncoderWrapperTest.java
Outdated
Show resolved
Hide resolved
fil512
approved these changes
Jan 26, 2022
hapi-fhir-base/src/main/java/ca/uhn/fhir/context/phonetic/PhoneticEncoderWrapper.java
Outdated
Show resolved
Hide resolved
hapi-fhir-base/src/main/java/ca/uhn/fhir/context/phonetic/PhoneticEncoderWrapper.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3336 +/- ##
============================================
+ Coverage 82.80% 82.84% +0.04%
- Complexity 20460 20494 +34
============================================
Files 1367 1369 +2
Lines 73521 73626 +105
Branches 11053 11064 +11
============================================
+ Hits 60882 60999 +117
+ Misses 8390 8372 -18
- Partials 4249 4255 +6
Continue to review full report at Codecov.
|
added 3 commits
January 26, 2022 15:56
tadgh
approved these changes
Jan 27, 2022
TipzCM
deleted the
3335-allow-alternative-character-encoding-length-in-searchparam
branch
michaelabuckley
pushed a commit
that referenced
this pull request
Jan 31, 2022
* added fixme * 2714 added support for specifying max code lengths for supported phonetic encoders * 3335git status * 3335 updated changelog * 3335 review fixes * review fixes * fixing test Co-authored-by: Ken Stevens <khstevens@gmail.com> Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local>
michaelabuckley
added a commit
that referenced
this pull request
Jan 31, 2022
* master: Add error codes to all exceptions (#3278) 3156 multiple tag race condition (#3297) Fix globbing pattern for log files Update instance_validator.md (#3328) add needed dependendencies for mysql and mssql (#3343) Add okhttp dep 3335 allow alternative character encoding length in searchparam (#3336) Fix mdm config for single application context environment. (#3338) Validate include statements for JPA (#3331) Add okhttp dep to r5 and indicate which deps need to be included (#3332) Bump RestEasy to 5.0.2 (#3329) # Conflicts: # hapi-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/ElasticsearchSvcImpl.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/dstu2/FhirResourceDaoDstu2SearchNoFtTest.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/subscription/module/matcher/InMemorySubscriptionMatcherR4Test.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3335
Added support to allow specifying max code length for phonetic encoders (for supported encoders only - metaphone and double_metaphone).
Added change log