3156 multiple tag race condition #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TipzCM
commented
Jan 13, 2022
TipzCM
commented
- Fixed race condition issue in BaseHapiFhirDao that could result in multiple tags of the same kind being created
- Added change log
katiesmilecdr
approved these changes
Jan 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #3297 +/- ##
============================================
- Coverage 82.85% 82.84% -0.01%
- Complexity 20495 20497 +2
============================================
Files 1369 1369
Lines 73626 73654 +28
Branches 11064 11066 +2
============================================
+ Hits 61001 61020 +19
- Misses 8370 8379 +9
Partials 4255 4255
Continue to review full report at Codecov.
|
tadgh
reviewed
Jan 18, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 18, 2022 13:18
jamesagnew
reviewed
Jan 20, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Show resolved
Hide resolved
jamesagnew
reviewed
Jan 20, 2022
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDaoTest.java
Show resolved
Hide resolved
jamesagnew
reviewed
Jan 21, 2022
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4CreateTest.java
Show resolved
Hide resolved
jamesagnew
reviewed
Jan 26, 2022
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDaoTest.java
Outdated
Show resolved
Hide resolved
jamesagnew
approved these changes
Jan 27, 2022
michaelabuckley
pushed a commit
that referenced
this pull request
Jan 31, 2022
* 3156 fix race condition that results in multiple tags being created * 3156 added changelog * cleanup * added smile jira ticket * 3156 review fixes * review fixes * 3156 added an additional integratoin test * cleanup * review fix and master merge * threadsafe stuff * small change * upping min threads for tests to pass * changing test * test check * fix * test testing * one more update * using threadpoolutil * temporary measure * git push * all builds Co-authored-by: leif stawnyczy <leifstawnyczy@leifs-MacBook-Pro.local>
michaelabuckley
added a commit
that referenced
this pull request
Jan 31, 2022
* master: Add error codes to all exceptions (#3278) 3156 multiple tag race condition (#3297) Fix globbing pattern for log files Update instance_validator.md (#3328) add needed dependendencies for mysql and mssql (#3343) Add okhttp dep 3335 allow alternative character encoding length in searchparam (#3336) Fix mdm config for single application context environment. (#3338) Validate include statements for JPA (#3331) Add okhttp dep to r5 and indicate which deps need to be included (#3332) Bump RestEasy to 5.0.2 (#3329) # Conflicts: # hapi-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/ElasticsearchSvcImpl.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/dstu2/FhirResourceDaoDstu2SearchNoFtTest.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/subscription/module/matcher/InMemorySubscriptionMatcherR4Test.java
tyfoni-systematic
pushed a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Feb 22, 2022
tyfoni-systematic
pushed a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Aug 4, 2022
tyfoni-systematic
pushed a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Sep 6, 2022
tyfoni-systematic
added a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Nov 17, 2022
tyfoni-systematic
added a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Nov 17, 2022
tyfoni-systematic
added a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Nov 21, 2022
tyfoni-systematic
added a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Nov 21, 2022
tyfoni-systematic
added a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Feb 21, 2023
tyfoni-systematic
added a commit
to tyfoni-systematic/hapi-fhir
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.