add needed dependendencies for mysql and mssql #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmuylwyk
approved these changes
Jan 28, 2022
|
Yup this is just the internal driver that is used based on the jdbc url provided. I'm essentially just checking "Hey is this non-null and have some sane value |
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
============================================
+ Coverage 82.81% 82.84% +0.03%
- Complexity 20471 20494 +23
============================================
Files 1367 1369 +2
Lines 73553 73626 +73
Branches 11055 11064 +9
============================================
+ Hits 60911 60995 +84
+ Misses 8392 8378 -14
- Partials 4250 4253 +3
Continue to review full report at Codecov.
|
michaelabuckley
pushed a commit
that referenced
this pull request
Jan 31, 2022
* add mssql and mysql flyway dependencies * add exclusions to CQL to prevent duplicate classes on the classpath * wip * ad more databases * finish test
michaelabuckley
added a commit
that referenced
this pull request
Jan 31, 2022
* master: Add error codes to all exceptions (#3278) 3156 multiple tag race condition (#3297) Fix globbing pattern for log files Update instance_validator.md (#3328) add needed dependendencies for mysql and mssql (#3343) Add okhttp dep 3335 allow alternative character encoding length in searchparam (#3336) Fix mdm config for single application context environment. (#3338) Validate include statements for JPA (#3331) Add okhttp dep to r5 and indicate which deps need to be included (#3332) Bump RestEasy to 5.0.2 (#3329) # Conflicts: # hapi-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/lastn/ElasticsearchSvcImpl.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/dstu2/FhirResourceDaoDstu2SearchNoFtTest.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/subscription/module/matcher/InMemorySubscriptionMatcherR4Test.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent upgrade in flyway versions caused a regression which meant that we can no longer connect to mysql or mssql databases, as the dependencies from flyway were pulled out into additional dependencies. This MR adds those dependencies, and writes a small test to catch if other dependencies are pulled out.