Validate theSearchParamRegistry is not null #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesagnew
approved these changes
Oct 23, 2020
HananAwwad
pushed a commit
to HananAwwad/hapi-fhir
that referenced
this pull request
Jan 6, 2021
HananAwwad
pushed a commit
to HananAwwad/hapi-fhir
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the R4 ConformanceProvider there are validations on
theRestfulServer,theSystemDao, andtheDaoConfigto be not null but no such validation fortheSearchParamRegistry.However, if you look at line 128 it assumes
mySearchParamRegistryis not null. Passing in a null value will cause a null pointer exception. Since these validations already exist it is easy enough to just add a check for the search param registry too.The DSTU2/3 Conformance Providers do not include this argument and the R5 version doesn't validate any of the arguments so I only added the check here.