Exposing parameters for HTTP client request pool max connections in RestfulClientFactory #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory: * added setters on restful client factory to allow changing max total connections and max connections per route for pooling http connection manager * added defaults for max total connections and max connections per route on restful client factory interface
|
Thanks! This looks awesome, merging it now. |
jamesagnew
added a commit
that referenced
this pull request
Jan 22, 2016
Exposing parameters for HTTP client request pool max connections in RestfulClientFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current RestfulClientFactory uses the default HTTP client PoolingHttpClientConnectionManager settings for max number of connections.
The defaults for these are 20 max total connections and 2 max per route.
These changes expose parameters on RestfulClientFactory to allow overriding these defaults.
The default for max connections per route is also changed here from 2 to 20 (using the same value as max total connections).
Other possible approaches: