Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6262 cds hooks returns 400 when extension passed in the cdsservicerequestjson #6274

Conversation

AD1306
Copy link
Collaborator

@AD1306 AD1306 commented Sep 9, 2024

closes #6262

@AD1306 AD1306 linked an issue Sep 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 9, 2024

Formatting check succeeded!

@AD1306 AD1306 marked this pull request as ready for review September 9, 2024 22:27
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (406db33) to head (bf1d494).
Report is 39 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6274      +/-   ##
============================================
+ Coverage     83.54%   83.59%   +0.05%     
- Complexity    27432    27563     +131     
============================================
  Files          1707     1715       +8     
  Lines        106185   106674     +489     
  Branches      13397    13434      +37     
============================================
+ Hits          88710    89173     +463     
+ Misses        11750    11741       -9     
- Partials       5725     5760      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VK-SMILECDR VK-SMILECDR self-requested a review September 16, 2024 19:18
@AD1306 AD1306 merged commit 1fad912 into master Sep 18, 2024
65 of 66 checks passed
@AD1306 AD1306 deleted the 6262-cds-hooks-returns-400-when-extension-passed-in-the-cdsservicerequestjson branch September 18, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDS hooks returns 400 when extension passed in the CdsServiceRequestJson
2 participants