Sort speedup submit to upstream #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has CI failures due to linting.
How big of an array are you sorting, and do you have any benchmarks that could accompany a change like this? |
Indeed. I'm also curious. Afaik, hapi is mostly optimized towards runtime performance. Adding new logic that only optimizes the boot process needs some extra weight behind it. |
|
We appreciate the contribution! I am closing for now due to inactivity, but would be open to considering a change like this if we can back it up with some numbers, and with adjustments so that hapi's linter is satisfied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native javascript sort of already-sorted arrays w/ custom comparators is known to be pathologically slow. We observed this behavior adding significant startup time to our application. Substituting an insertion algorithm based on binary search reduced startup time by several seconds.