allow null setting for domain

[mshick]

Per #64 allows domains to be set to null an allowed value for server.state.

[gansbrest]

yep, +1 )

[jaw187]

Since Statehood sets domain to null via defaults, this isn't needed.

[mshick]

Sure, that makes sense. It's worth pointing out though, that with the validation happening first there's no way to trigger that branch of logic -- no falsey value will pass validation for domain, presently.

[jaw187]

@mshick include changes for redirectTo as well and any other property which you need to send falsey values for.

[jaw187]

@gansbrest Do you have an specific property and falsey value which you need support for?

[mshick]

Okay, will do. I’ll push up the validation change in a sec, along with a test.

I don’t mean to badger you. If redirectTo isn’t a change you want to make I understand.

On Apr 30, 2015, at 10:04 AM, James Weston notifications@github.com wrote:

@mshick https://github.com/mshick include changes for redirectTo as well and any other property which you need to send falsey values for.

—
Reply to this email directly or view it on GitHub #65 (comment).

[hofan41]

Should domain also be changed to allow false?

[mshick]

Null is allowed by statehood, false is not. That's the rationale -- consistency.

On Apr 30, 2015, at 1:49 PM, Ho-Fan Kang notifications@github.com wrote:

Should domain also be changed to allow false?

―
Reply to this email directly or view it on GitHub.

[jaw187]

This should be allow('')

[mshick]

I used false to be consistent with the docs for redirectTo at the route level:

 To set an individual route to use or disable redirections, use the route plugins config ({ config: { plugins: { 'hapi-auth-cookie': { redirectTo: false } } } }). Defaults to no redirection.

In light of that, would you still like me to change it?

[jaw187]

You're right, the allow value will override the data type.

> Joi.validate(false, Joi.string().allow(false))
{ error: null, value: false }

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.