Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server.settings.cors.origin if allowOrigins unset and CORS enabled #30

Closed
stongo opened this issue Sep 30, 2014 · 2 comments
Closed

Use server.settings.cors.origin if allowOrigins unset and CORS enabled #30

stongo opened this issue Sep 30, 2014 · 2 comments
Assignees
@stongo
Labels
feature New functionality or improvement

Comments

@stongo
Copy link
Contributor

stongo commented Sep 30, 2014

This will allow Crumb to work out of the box with CORS, but will still allow finer grained control of setting the crumb cookie to allowed CORS origins if desired.
@stongo stongo added the feature New functionality or improvement label Sep 30, 2014
@stongo stongo self-assigned this Sep 30, 2014
@stongo stongo mentioned this issue Sep 30, 2014
Closed
@stongo stongo changed the title Use server.settings.cors.host if allowOrigins unset and CORS enabled Use server.settings.cors.origin if allowOrigins unset and CORS enabled Oct 1, 2014
stongo added a commit that referenced this issue Oct 1, 2014
@stongo
bring test coverage to 100%, adds feature from #30
b83e51a
@stongo
Copy link
Contributor Author

stongo commented Oct 3, 2014

Done

@stongo stongo closed this as completed Oct 3, 2014
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stongo stongo

Labels
feature New functionality or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stongo