Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node v18 and hapi v21, drop node v12 and hapi v19 #164

Merged
merged 5 commits into from
Jul 17, 2022
Merged

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented Jun 27, 2022

  • Test on node v14+ and hapi v20+.
  • Update to node v18-compatible versions of hapi modules, update lru-cache.
  • Ensure all exports are available when used as ESM module.

If this looks good, this will go out as inert v7.

This PR may be used as an example of a plugin update for node v18 and hapi v21. Here's the checklist:

  • Update the license for the current year.
  • Update the workflow file to test on node v14+ and hapi v20+.
  • Ensure that node support is up-to-date on engines field in package.json if present (supports node v14+).
  • Ensure that node and hapi support is up-to-date on plugin requirements attribute if present (supports node v14+ and hapi v20+).
  • Update JS syntax, utilizing optional chaining x?.y and nullish coalescing (x ?? y) where appropriate.
  • Update dependencies.
  • Add a test file esm/test.js testing the module's ESM exports.
  • We decided not to do this for plugins. Add an additional explicitly-named export for each plugin, e.g. inertPlugin for inert, visionPlugin for vision, etc.

@devinivy devinivy added dependency Update module dependency breaking changes Change that can breaking existing code labels Jun 27, 2022
@devinivy devinivy added this to the 7.0.0 milestone Jun 27, 2022
lib/index.js Outdated Show resolved Hide resolved
API.md Outdated Show resolved Hide resolved
@devinivy devinivy merged commit e11b34d into master Jul 17, 2022
@devinivy devinivy deleted the v7 branch July 17, 2022 21:07
@devinivy devinivy self-assigned this Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants