Print string versions of NaN, Infinity and -Infinity - resolves #696

[mdibaiee]

#696

Edit: I forgot to add tests, will add now.

[Marsup]

That's not really what I had in mind, it's not exactly done like that in lab. I'd like to be able to substitute with the correct syntax afterwards so with simple strings it won't be enough.

[mdibaiee]

@Marsup: I'll see if I can find a reference in lab's source.

[Marsup]

It's in the console reporter.

[mdibaiee]

@Marsup: Thanks for the reference, I think it's better now.

Do we have to handle Functions and Symbols, too?

[Marsup]

Ideally yes. You'll also need that post-replace I talked about.

[mdibaiee]

@Marsup Sorry about the delay.

By post-replace do you mean converting the serialized values back?

Do we already have a function doing this (I couldn't find one) or do I have to add it to internals? If so, any idea on the name? I'd say deserialize

[Marsup]

The annotate function is doing that with regexps at the bottom.

[mdibaiee]

@Marsup Alright, I think this is what you want, if there are any further changes required, ask right away.

[Marsup]

I think the function will be a little more complex than that if you have brackets inside the code.

[mdibaiee]

@Marsup It seems to work as .* is greedy and continues until the last bracket, I modified the test as a proof.

[Marsup]

Then you're just lucky the function is last.

[mdibaiee]

@Marsup

This input:

{
  "x": {
    "z": "[Infinity]",
    "f": "[function (x) { return [ { y: 2 } ]; }]",
    "u": "[-Infinity]",
    "y_$key$_1_$end$_": "[NaN]"
  }

gives this:

function (x) { return [ { y: 2 } ]; }

I think that's because each property is put on a newline, which in turn counts the last bracket of function as the last bracket of the current line, if that always happens in stringify, we're fine, else we should do something more complex to find out the "actual" closing bracket. Does stringify always put properties in new lines? Yes, because we pass an space argument which indents the object.

Now another question rises here, are functions always inlined? I found out that while stringifying, because we manually use fn.toString(), the function's linebreaks turn into \n characters, so we always have a single-line string, which in turn works with the used Regular Expression.

Edit: But I'm not sure about arrays, let me see.
Edit: Each array element is put on a new line when using the space argument.

[Marsup]

Can you try with multiple of each in the tests to make sure all are replaced ?

[Marsup]

Merged manually as 0301604 with a few modifications, thanks for the ground work.

[mdibaiee]

@Marsup: Sorry, I had completely forgot about it, thanks.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.