Skip to content

Conversation

akihito-takeuchi
Copy link
Contributor

Hapi team,

I added Japanese translations to makemehapi workshopper. When I was translating the exercises, I had some questions as below.

  • In "validation" exercise, I don't really understand the following sentence well. Could you elaborate it?

The solution will just check that a Validation object exists within the configuration for breed, not any specific validation.

  • The "HINT" section of Validation exercises said that the server should listen to port 8080, but I think the server should listen to the port number which passed from the command line.

  • Some exercises refer to the document at {rootdir:/node_modules/hapi/API.md}, but I could not find it. Should we change it to refer to http://hapijs.com/api ?

Best regards,
Takeuchi

@fiveisprime
Copy link
Contributor

fiveisprime commented Nov 27, 2016

Thank you so much for this! :)

  • That sentence means that breed only needs to be provided and there's no check for the content of the param
  • You are correct, the exercise should say to "...listen on port 8080, if no port is passed from the command line"
  • Yes! Can you create a new issue for that so we can make sure all doc links are updated?

@akihito-takeuchi
Copy link
Contributor Author

Thank you for your answer! I updated the translation based on your information. I believe that my changes are ready to merge now. Could you merge this pull request?

Yes, I'll create an issue for doc link!

@fiveisprime fiveisprime merged commit cc55e9b into ccarruitero:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants