Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support objection v2 #3

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Support objection v2 #3

merged 1 commit into from
Dec 6, 2019

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented Dec 6, 2019

As far as I can tell this already works great with objection v2, and it just needs to declare that as a peer dependency. It's worth noting that db-errors is now used directly by objection, so issues could arise in the future if this module's db-errors dependency isn't identical to objection's. With a breaking change this library could probably drop support for objection v1, remove the wrapError() call, and be less likely to get into dependency tangles.

@coveralls
Copy link

coveralls commented Dec 6, 2019

Pull Request Test Coverage Report for Build 15

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14: 0.0%
Covered Lines: 213
Relevant Lines: 213

💛 - Coveralls

@optii
Copy link
Collaborator

optii commented Dec 6, 2019

Looks good to me, haven't had time to dig into the objection v2 changes, but I did notice that the DbErrors had been integrated, and making the changes you suggest above seem like the right way forward. I will open an issue to re-state what you said above, as to not loose it.

@optii optii merged commit ce8bbc2 into hapipal:master Dec 6, 2019
@optii optii mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants