Update eslint v4 to v8, prettier v2 to v3 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to get these dependencies updated so things say fresh. eslint v9 is it out, but I'm only going to v8 first since v9 is a much larger change. I'll fix any errors in a followup.
This addresses a bunch of new errors that appeared after updating eslint.
This plugin turns off all rules that might conflict with prettier. Since we are using prettier here, this seems appropriate.
This makes the linter clean and happy.
Just keeping things fresh!
lencioni
changed the title
trotzig
approved these changes
Jun 27, 2024
| @@ -9,7 +9,7 @@ export default function validateArchive(totalBytes, entries) { | |||
| ]; | |||
| const fileSizes = entries.map((entry) => ({ | |||
| name: entry.name, | |||
| size: entry.stats ? entry.stats.size : (entry.size || 0), | |||
| size: entry.stats ? entry.stats.size : entry.size || 0, | |||
There was a problem hiding this comment.
Not important but this change seemed to make things harder to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings our linter more up to date. I didn't go all the way to v9 because it is a pretty big change from v8.
This is probably best reviewed commit by commit.